Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix html #1548

Merged
merged 1 commit into from
Jul 31, 2024
Merged

fix html #1548

merged 1 commit into from
Jul 31, 2024

Conversation

spaette
Copy link
Contributor

@spaette spaette commented Jul 28, 2024

this is a copy/paste from googlesheets4

@jennybc
Copy link
Member

jennybc commented Jul 30, 2024

This is not necessarily critique but I'm wondering: are you detecting a problem with the current site? There's no problem with the naked eye for me.

@spaette
Copy link
Contributor Author

spaette commented Jul 30, 2024

current site

as opened in Chromium and Firefox

likely due to <img> element's extra / at the end

<img src="https://github.com/rstudio/cheatsheets/raw/main/pngs/thumbnails/data-import-cheatsheet-
thumbs.png" height="252" alt="thumbnail of tidyverse data import cheatsheet"//>

copy/paste from googlesheets4

this does two things regarding the user interface

  • renders cheatsheets/data-import.pdf
  • eliminates the redirect occurring for the image file

a download icon accompanies the .pdf rendering whereas currently the file is downloaded to a default directory

@jennybc
Copy link
Member

jennybc commented Jul 30, 2024

OK I'm happy to update. The extra slash is clearly a mistake that I guess some browsers cope with.

The official workflow is to edit README.Rmd as per:

<!-- README.md is generated from README.Rmd. Please edit that file -->

then call devtools::build_readme(). If you don't update the PR, I will next time I come through here.

@spaette spaette marked this pull request as draft July 31, 2024 14:52
@spaette spaette marked this pull request as ready for review July 31, 2024 15:03
@jennybc
Copy link
Member

jennybc commented Jul 31, 2024

Thanks!

@jennybc jennybc merged commit 96ddac3 into tidyverse:main Jul 31, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants